Alexander Wels has posted comments on this change.
Change subject: webadmin: TreeTable no items to display
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractSubTabTreeView.java
Line 102: // use the fact that we are using a table to display the
'header' to have
Line 103: // it display the no items to display message.
Line 104: if (sender instanceof ListModel) {
Line 105: ListModel model = (ListModel) sender;
Line 106: if (model.getItems() == null || ((List<M>)
model.getItems()).isEmpty()) {
I am not happy with whomever decided to make this an iterator instead of a
collection. Then I wouldn't have had to cast at all. But you are right I should
check this one as well. But as we both know this will always be a list of some
sort :)
Line 107: table.setEmptyTableWidget(new
NoItemsLabel(model.getTitle()));
Line 108: } else {
Line 109: table.setEmptyTableWidget(null);
Line 110: }
--
To view, visit http://gerrit.ovirt.org/12738
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I508cf4c9ca61ceb58d4647d3074ae7638a8adcd6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
