Juan Hernandez has posted comments on this change.
Change subject: build: solve m2e manifest problems
......................................................................
Patch Set 1: (4 inline comments)
I think it is better to use the "pluginManagement" section, but other than that
I don't have objection.
Note that this may affect the creation of the RPM packages. Please verify that
you can still create RPM packages, install and run them successfully.
....................................................
File backend/manager/modules/restapi/webapp/pom.xml
Line 31: <build>
Line 32: <plugins>
Line 33: <plugin>
Line 34: <artifactId>maven-war-plugin</artifactId>
Line 35: <version>${maven-war-plugin.version}</version>
Dont use this property here, change the version number in the
"pluginManagement" section of the root POM instead.
Line 36: <configuration>
Line 37:
Line 38: <!-- Add a the manifest that contains the required
Line 39: dependencies for JBoss modules: -->
....................................................
File backend/manager/modules/root/pom.xml
Line 66:
Line 67: <plugin>
Line 68: <groupId>org.apache.maven.plugins</groupId>
Line 69: <artifactId>maven-war-plugin</artifactId>
Line 70: <version>${maven-war-plugin.version}</version>
Dont use this property here, change the version number in the
"pluginManagement" section of the root POM instead.
Line 71: <configuration>
Line 72: <archive>
Line 73: <addMavenDescriptor>false</addMavenDescriptor>
Line 74:
<manifestFile>src/main/resources/META-INF/MANIFEST.MF</manifestFile>
....................................................
File ear/pom.xml
Line 152:
Line 153: <plugins>
Line 154: <plugin>
Line 155: <artifactId>maven-ear-plugin</artifactId>
Line 156: <version>${maven-ear-plugin.version}</version>
Dont use this property here, change the version number in the
"pluginManagement" section of the root POM instead.
Line 157: <configuration>
Line 158: <!-- params common to ear:ear and
ear:generate-application-xml -->
Line 159: <defaultLibBundleDir>lib</defaultLibBundleDir>
Line 160: <workDirectory>${earDirectory}</workDirectory>
....................................................
File pom.xml
Line 88:
<maven-compiler-plugin.version>2.3.2</maven-compiler-plugin.version>
Line 89: <gwt.plugin.version>2.3.0</gwt.plugin.version>
Line 90: <test-jar.plugin.version>2.2</test-jar.plugin.version>
Line 91: <maven-war-plugin.version>2.1.1</maven-war-plugin.version>
Line 92: <maven-ear-plugin.version>2.6</maven-ear-plugin.version>
Instead of introducing these new properties change the version numbers in the
"pluginManagementSection". Then there is no need to make a reference to these
property everywhere.
Line 93:
<jboss-modules.plugin.version>1.0-SNAPSHOT</jboss-modules.plugin.version>
Line 94: </properties>
Line 95: <dependencyManagement>
Line 96: <dependencies>
--
To view, visit http://gerrit.ovirt.org/12870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib678e50b9403ae16415f5e10fb8f1e9a58d77661
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
