Arik Hadas has posted comments on this change.
Change subject: core: remove duplicate event on successful hibernation
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
Line 347: }
Line 348: setSucceeded(true);
Line 349: } else {
Line 350: log.errorFormat("hibernation volume of VM '{0}',
is not initialized.", getVm().getName());
Line 351: endWithFailure();
yes it seems like that. it was done before moving to git - can you check in the
previous repository to see if the guy that implemented it explained why not
having an audit message here? (I just preserved the current behaviour, didn't
pay much attention to it)
Line 352: }
Line 353: }
Line 354: }
Line 355:
--
To view, visit http://gerrit.ovirt.org/12838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5445374ddf6996e696c71995fe3bd2a9ddd60a85
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
