Vered Volansky has posted comments on this change.
Change subject: core: disk_image_dynamic statistics (#892596)
......................................................................
Patch Set 4: (3 inline comments)
Liron. this is the design we agreed upon in the short time frame that we have.
We decided the db queries overhead is acceptable for now. It will be properly
fixed as mentioned in the bz in the future (RFE 920211).
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1705: for (DiskImageDynamic imageDynamic :
_runningVms.get(vmToUpdate.getId()).getVmDynamic().getDisks()) {
Line 1706: Disk disk =
getDbFacade().getDiskDao().get(imageDynamic.getId());
Line 1707: // We have disk_id statistics, which is good, but
disk_image_dynamic table contains image_id, so we
Line 1708: // update for the AI.
Line 1709: if (disk instanceof DiskImage) {
Done
Line 1710: DiskImage diskImage = (DiskImage) disk;
Line 1711: Guid ActiveImageId = diskImage.getImageId();
Line 1712: imageDynamic.setId(ActiveImageId);
Line 1713: _vmDiskImageDynamicToSave.put(ActiveImageId,
imageDynamic);
Line 1707: // We have disk_id statistics, which is good, but
disk_image_dynamic table contains image_id, so we
Line 1708: // update for the AI.
Line 1709: if (disk instanceof DiskImage) {
Line 1710: DiskImage diskImage = (DiskImage) disk;
Line 1711: Guid ActiveImageId = diskImage.getImageId();
Done
Line 1712: imageDynamic.setId(ActiveImageId);
Line 1713: _vmDiskImageDynamicToSave.put(ActiveImageId,
imageDynamic);
Line 1714: }
Line 1715: }
Line 1707: // We have disk_id statistics, which is good, but
disk_image_dynamic table contains image_id, so we
Line 1708: // update for the AI.
Line 1709: if (disk instanceof DiskImage) {
Line 1710: DiskImage diskImage = (DiskImage) disk;
Line 1711: Guid ActiveImageId = diskImage.getImageId();
Done
Line 1712: imageDynamic.setId(ActiveImageId);
Line 1713: _vmDiskImageDynamicToSave.put(ActiveImageId,
imageDynamic);
Line 1714: }
Line 1715: }
--
To view, visit http://gerrit.ovirt.org/12961
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f49238e3a725184ad2feb2d5ff06996e462d377
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
