Mike Kolesnik has posted comments on this change.
Change subject: engine: Validate Dup MAC Addresses upon Iface Plug
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
Line 154: private boolean hotPlugVmNicRequired(VMStatus vmStatus) {
Line 155: return vmStatus == VMStatus.Up;
Line 156: }
Line 157:
Line 158: protected ValidationResult macAvailable(VmNetworkInterface
vmNetworkInterface) {
Not really necessary to send the NIC since you take it from the parameters
anyway
Line 159: Boolean allowDupMacs = Config.<Boolean>
GetValue(ConfigValues.AllowDuplicateMacAddresses);
Line 160: VmInterfaceManager vmInterfaceManager = new
VmInterfaceManager();
Line 161: if (allowDupMacs ||
!vmInterfaceManager.existsPluggedInterfaceWithSameMac(vmNetworkInterface)) {
Line 162: return ValidationResult.VALID;
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
Line 328: * <li>mac_addr: 00:1a:4a:16:87:db</li>
Line 329: * <li>name: nic1</li>
Line 330: * </ul>
Line 331: */
Line 332: public static final Guid VM_NETWORK_INTERFACE2 = new
Guid("14550e82-1e1f-47b5-ae41-b009348dabfb");
Didn't see use for it, is it still needed?
Line 333:
Line 334: /**
Line 335: * Predefined VmNetworkInterface with the following properties:
Line 336: * <ul>
--
To view, visit http://gerrit.ovirt.org/12242
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1476e8bec112c0c592e5cc16deefcf67076f5dc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
