Allon Mureinik has posted comments on this change.
Change subject: core: Failed install DB during rhevm-setup...
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
Giving -1 based on my concern about the y/n switch (see inline), so this
doesn't get merged by mistake.
[Not saying that I'm necessarily right here, but if I'm not, I'd like to see an
explanation].
The other two are just enhancement ideas, not "blockers".
....................................................
File backend/manager/tools/dbutils/encodingvalidator.sh
Line 27: printf "\t-h - This help text.\n"
Line 28: printf "\n"
Line 29: popd>/dev/null
Line 30: exit $ret
Line 31: }
General - most of the db scripts have a bunch of common parameters (username,
dbname, etc.) - perhaps this could be extracted to a common place?
Line 32:
Line 33: DEBUG () {
Line 34: if $VERBOSE; then
Line 35: printf "DEBUG: $*"
Line 80: CMD="UPDATE pg_database SET datistemplate = TRUE WHERE datname =
'template1';"
Line 81: run "${CMD}" template0
Line 82: #restore changed defaults for template0
Line 83: CMD="UPDATE pg_database SET datallowconn = FALSE WHERE datname =
'template0';"
Line 84: run "${CMD}" template1
You're assuming the user is using pg's default templates.
Is there any value for having an additional, optional "templateName" parameter?
Line 85: }
Line 86:
Line 87: if [ "${FIXIT}" = "true" ]; then
Line 88: echo "Caution, this operation should be used with care. Please
contact support prior to running this command"
Line 88: echo "Caution, this operation should be used with care. Please
contact support prior to running this command"
Line 89: echo "Are you sure you want to proceed? [y/n]"
Line 90: read answer
Line 91:
Line 92: if [ "${answer}" = "n" ]; then
Unless I'm missing something, anything other than "n" will be interpreted as
"y".
This, IMHO, is a problematic direction - suppose I mean "n", but press "m" by
mistake...
Line 93: echo "Please contact support for further assistance."
Line 94: popd>/dev/null
Line 95: exit 1
Line 96: fi
....................................................
Commit Message
Line 3: AuthorDate: 2013-03-10 17:07:06 +0200
Line 4: Commit: Eli Mesika <[email protected]>
Line 5: CommitDate: 2013-03-12 13:10:20 +0200
Line 6:
Line 7: core: Failed install DB during rhevm-setup...
Don't you mean oVirt setup?
Line 8:
Line 9: Failed install DB during rhevm-setup not on clean server
Line 10:
Line 11: This patch adds a utility encodingvalidator.sh that can be used to
--
To view, visit http://gerrit.ovirt.org/12966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74dd62ec2c0f96d719b15848da4e08d8f6cc5068
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
