Tal Nisan has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
Line 38: @Override
Line 39: protected boolean canDoAction() {
Line 40: StorageServerConnections newConnectionDetails =
getParameters().getStorageServerConnection();
Line 41:
Line 42: if (newConnectionDetails.getstorage_type() != StorageType.NFS)
{
Might be overkill, but I think it might be worth to also check that the storage
pool is of NFS type
Line 43: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_CONNECTION_UNSUPPORTED_ACTION_FOR_STORAGE);
Line 44: }
Line 45:
Line 46: // Check if the NFS path has a valid format
--
To view, visit http://gerrit.ovirt.org/12372
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaff5344ff191d6bdf53cc706c7bb796167a56b3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
