Alona Kaplan has posted comments on this change.
Change subject: webadmin: Added ValueSuggestBox widget
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ValueSuggestBox.java
Line 66:
Line 67: if (stringToValue.containsKey(currentText)) {
Line 68: setValue(stringToValue.get(currentText), true);
Line 69: } else {
Line 70:
setValue(ValueSuggestBox.this.factory.getObjectForString(currentText), true);
I think that it is wrong design for the view to create the business entity.
The model should do it.
The suggest box should hold just the strings, the model should do the work
converting the strings to objects.
Line 71: }
Line 72: }
Line 73: });
Line 74:
--
To view, visit http://gerrit.ovirt.org/12529
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07d419d0eb83e189b6bf6138c6e4b2b6953a2012
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
