Alon Bar-Lev has posted comments on this change.
Change subject: pki: use relative lock file
......................................................................
Patch Set 2: (2 inline comments)
> First of all this is more than changing a path location, this is also
> removing rollbacks. In most cases it would be much better to have it in
> separate patches.
No it belongs to the same patch, as you cannot guarantee persistency at
/var/lock.
> Also, can you please explain why did you remove the rollback?
I explained inline... there is no reason to remove this file, so we can just
reuse the same file for locking.
....................................................
File backend/manager/conf/ca/SignReq.sh
Line 56: timeout=$8
Line 57: if [ -z "$timeout" ]; then
Line 58: timeout=20
Line 59: fi
Line 60:
Not at all. The lock is not the existence of the file but the lock on the file,
there is no need to remove the file.
Line 61: {
Line 62: # Wait for lock on $lock_file (fd 200) for $timeout seconds
Line 63: flock -e -w $timeout 200 || die "Timeout waiting for lock.
Giving up"
Line 64: sign
Line 60:
Line 61: {
Line 62: # Wait for lock on $lock_file (fd 200) for $timeout seconds
Line 63: flock -e -w $timeout 200 || die "Timeout waiting for lock.
Giving up"
Line 64: sign
Done
Line 65: result=$?
Line 66:
Line 67: } 200>$lock_file
Line 68:
--
To view, visit http://gerrit.ovirt.org/13030
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4274778254167db8f632908a9bdcc0d6ad284b3e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
