Moti Asayag has posted comments on this change.
Change subject: engine: Verify network is VM network by scheduler
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
Line 446: if (!vmIface.isPlugged()) {
Line 447: networkRequiredOnVds = false;
Line 448: } else if (onlyRequiredNetworks) {
Line 449: Network network =
networksByName.get(vmIface.getNetworkName());
Line 450: networkRequiredOnVds = network.getCluster().isRequired()
&& network.isVmNetwork();
There is a can-do-action on when adding new interface which validates the
network is a VM network.
But currently there is an option to update an existing network on the nic to a
non-vm network (haven't tried actually to perform it - will try using rest
later-on).
In any case - the network is already being examined within the
RunVmCommand.canDoAction by validateNetworkInterfaces() method for a proper
network configuration, so this check is redundant.
Line 451: }
Line 452: return networkRequiredOnVds;
Line 453: }
Line 454:
--
To view, visit http://gerrit.ovirt.org/13021
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2adfe6b65146d5c780538c1b4ac6d86b56256331
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
