Juan Hernandez has posted comments on this change. Change subject: webadmin: enable gzip compression ......................................................................
Patch Set 9: Looks good to me, but someone else must approve (2 inline comments) A couple of extra-minor comments inside, feel free to ignore them. .................................................... File packaging/fedora/engine-service.xml.in Line 20: Line 21: <system-properties> Line 22: <!-- Don't let quartz call home to check for updates: --> Line 23: <property name="org.quartz.scheduler.skipUpdateCheck" value="true"/> Line 24: <property name="org.apache.coyote.http11.Http11Protocol.COMPRESSION" value="on"/> I would suggest adding a blank line, to separate from the previous property, and a short comment explaining that this enables compression of the content for web pages and REST API. Line 25: <property name="org.apache.coyote.http11.Http11Protocol.COMPRESSION_MIME_TYPES" value="text/javascript,text/css,text/html,text/xml,text/json,application/x-yaml,application/xml,application/json"/> Line 26: </system-properties> Line 27: Line 28: <profile> Line 21: <system-properties> Line 22: <!-- Don't let quartz call home to check for updates: --> Line 23: <property name="org.quartz.scheduler.skipUpdateCheck" value="true"/> Line 24: <property name="org.apache.coyote.http11.Http11Protocol.COMPRESSION" value="on"/> Line 25: <property name="org.apache.coyote.http11.Http11Protocol.COMPRESSION_MIME_TYPES" value="text/javascript,text/css,text/html,text/xml,text/json,application/x-yaml,application/xml,application/json"/> Also a blank line here. Line 26: </system-properties> Line 27: Line 28: <profile> Line 29: -- To view, visit http://gerrit.ovirt.org/10911 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c0c5f88c1f58fc98775734f075bfa0bc867f8fc Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
