Allon Mureinik has posted comments on this change.
Change subject: core: Cannot confirm Host has been rebooted when..
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
See inline some implementation considerations.
Also, according to comment 20 of the BZ:
"Use cases covered:
1. Any systems without fencing devices
2. Single host use case
3. Malfunction fence device"
This patch seems to handle #2 only. Is this correct?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java
Line 91:
Line 92: @Override
Line 93: protected void executeCommand() {
Line 94: boolean result = true;
Line 95: boolean isSingleHostInDC =
getVdsDAO().getAllForStoragePool(getStoragePool().getId()).size() == 1;
This is an extra DAO call that's only used if (_problematicVds.getSpmStatus()
== VdsSpmStatus.SPM) - don't perform it if isn't required.
Line 96: setVdsName(_problematicVds.getName());
Line 97: if (_problematicVds.getSpmStatus() == VdsSpmStatus.SPM) {
Line 98: result = ActivateDataCenter();
Line 99: if (isSingleHostInDC) {
....................................................
Commit Message
Line 17: 1) Making the Host responsive again => Host is SPM back
Line 18: 2) Adding another Host => New Host is SPM
Line 19:
Line 20: This patch is not handling the case in which the problematic Host has
Line 21: running VMs, only the scenario reported in 6the BZ was handled
s/6the/the/
Line 22:
Line 23: Change-Id: I8264d91d6dc5f33e4684d3bef86624b6f424a64b
Line 24: Signed-off-by: Eli Mesika <[email protected]>
--
To view, visit http://gerrit.ovirt.org/13045
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8264d91d6dc5f33e4684d3bef86624b6f424a64b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
