Michael Kublin has uploaded a new change for review. Change subject: engine: Making all internal actions to have same correlationId ......................................................................
engine: Making all internal actions to have same correlationId The following patch will force all internal actions to have same correlationId. When an action triggered from gui or rest client, it should pass a correlationId otherwise it will be automaticly generated. But, if action has some another internal actions they will have different correlationId. This patch will fix a problem. Discovered during work on provided bug This patch is addition to previous with Change-Id: I47ad8e04452b7f0e3f5f8477f84bc6b22e35ec98, in which I did some mistake. I have not explanation why I did such stupid mistake Change-Id: Ib12f9079a564bb507b3a3a0f84601e918bd92b3f Bug-Url: https://bugzilla.redhat.com/844335 Signed-off-by: Michael Kublin <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/01/13101/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java index c088b26..26847d5 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java @@ -632,8 +632,9 @@ if (StringUtils.isEmpty(correlationId)) { correlationId = ThreadLocalParamsContainer.getCorrelationId(); if (StringUtils.isEmpty(correlationId)) { - parameters.setCorrelationId(LoggedUtils.getObjectId(parameters)); + correlationId = LoggedUtils.getObjectId(parameters); } + parameters.setCorrelationId(correlationId); } else { List<String> messages = ValidationUtils.validateInputs(validationGroups, parameters); if (!messages.isEmpty()) { -- To view, visit http://gerrit.ovirt.org/13101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib12f9079a564bb507b3a3a0f84601e918bd92b3f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
