Vered Volansky has posted comments on this change.
Change subject: core: Allow force re-election of a specific host as SPM
......................................................................
Patch Set 4: (5 inline comments)
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 79: VDS_CANNOT_REMOVE_VDS_STATUS_ILLEGAL=Cannot ${action} ${type}. Host is
operational. Please switch Host to Maintenance mode first.
Line 80: VDS_NOT_EXIST=Cannot ${action} ${type}. Internal Error: Host does not
exists in DB.
Line 81: CANNOT_REINIT_SPM_VDS_NOT_UP=Cannot ${action} ${type}. The Host
${VdsName} is not active.
Line 82: CANNOT_REINIT_SPM_VDS_ALREADY_SPM=Cannot ${action} ${type}. The Host
${VdsName} is already SPM or contending.
Line 83: CANNOT_REINIT_SPM_VDS_MARKED_AS_NEVER_SPM=Cannot ${action} ${type}.
The SPM priority of Host ${VdsName} is set to never. This Host can not be
elected as SPM.
s/can not/cannot
Line 84: VDS_PROTOCOL_ERROR=Internal error: Host protocol error.
Line 85: VDS_RESPONSE_ERROR=Internal error: Host response error
Line 86: VDS_STATUS_NOT_VALID_FOR_STOP=Cannot perform Stop operation, Host has
to be in Maintenance mode in order to be stopped.
Line 87: VDS_STATUS_NOT_VALID_FOR_START=Cannot perform Start operation, Host
has to be in one of the following statuses: Down ,Non-Responsive or Maintenance.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 188: }
Line 189:
Line 190: }
Line 191: }
Line 192: } catch (Exception ex) {
Did you ignore Allon's comment regarding empty blocks on purpose?
Line 193: }
Line 194: }
Line 195:
Line 196: private int _errorAttempts;
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
Line 81: import org.ovirt.engine.ui.uicompat.ReversibleFlow;
Line 82:
Line 83: @SuppressWarnings("unused")
Line 84: public class HostListModel extends ListWithDetailsModel implements
ISupportSystemTreeContext
Line 85: {
OMG this is hideous. I know it's unrelated to the patch, but pleeeeease
consider a cleanup.
Line 86: private UICommand privateNewCommand;
Line 87:
Line 88: public UICommand getNewCommand()
Line 89: {
Line 131: {
Line 132: privateRemoveCommand = value;
Line 133: }
Line 134:
Line 135: private UICommand setAsSpmCommand;
Problematic naming with regard to setter/getter. I don't have a better idea
though. Maybe another reviewer will...
Line 136:
Line 137: public UICommand getSetAsSpmCommand()
Line 138: {
Line 139: return setAsSpmCommand;
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 79: VDS_CANNOT_REMOVE_VDS_STATUS_ILLEGAL=Cannot ${action} ${type}. Host is
operational. Please switch Host to Maintenance mode first.
Line 80: VDS_NOT_EXIST=Cannot ${action} ${type}. Internal Error: Host does not
exists in DB.
Line 81: CANNOT_REINIT_SPM_VDS_NOT_UP=Cannot ${action} ${type}. The Host
${VdsName} is not active.
Line 82: CANNOT_REINIT_SPM_VDS_ALREADY_SPM=Cannot ${action} ${type}. The Host
${VdsName} is already SPM or contending.
Line 83: CANNOT_REINIT_SPM_VDS_MARKED_AS_NEVER_SPM=Cannot ${action} ${type}.
The SPM priority of Host ${VdsName} is set to never. This Host can not be
elected as SPM.
s/can not/cannot
Line 84: VDS_PROTOCOL_ERROR=Internal error: Host protocol error.
Line 85: VDS_RESPONSE_ERROR=Internal error: Host response error
Line 86: VDS_STATUS_NOT_VALID_FOR_STOP=Cannot perform Stop operation, Host has
to be in Maintenance mode in order to be stopped.
Line 87: VDS_STATUS_NOT_VALID_FOR_START=Cannot perform Start operation, Host
has to be in one of the following statuses: Down ,Non-Responsive or Maintenance.
--
To view, visit http://gerrit.ovirt.org/12489
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife292b85270e6aa8f5bf723ad7d3fa84e325d3d8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
