Roy Golan has posted comments on this change.
Change subject: core: introduce osinfo service instead of Config values
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/LibosinfoClient.java
Line 86:
Line 87: String options = "-Djava.rmi.server.hostname=localhost";
Line 88: String mainClassName =
"org.ovirt.engine.core.osinfo.server.LibosinfoServer";
Line 89:
Line 90: builder.command(java, "-cp", classpath, options,
mainClassName);
I can, at build-time query the libosinfo and generate a sql file from it (or a
db file), which will be loaded to an im-memory db when the engine starts and
will be easy to query (h2, infinispan maybe? )
the downside of reading the xml's is we re-implement libosinfo, we don't gain
their work on the api or features they add. just the raw data. Also to support
upgrades of libosinfo data, we would need to update the generator script (Don't
think its critic to support live upgrade of libosinfo)
the upside is that its definitely simpler than libosinfo as a system service,
it doesn't have a remote call, or JNA usage, more complicated for dev
environments etc.
also this pre-loaded db could not fail the engine is the ways using the
external library posed. It is also easy to layer the data with engine-specific
details like internal engine versions and their, supported OS devices.
Line 91: return builder;
Line 92: }
Line 93:
Line 94: private ProcessBuilder buildShellProcessCmd() {
--
To view, visit http://gerrit.ovirt.org/12936
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd75679a1a1af5d5a0925e181b5dfd6e87574a75
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
