Libor Spevak has posted comments on this change. Change subject: webadmin,userportal: Remove '__gwt_historyFrame' iframe ......................................................................
Patch Set 1: Looks good to me, but someone else must approve This is useful, but still, I noticed IE8 is a real challenge. I noticed the browser is unhappy with another iframe generated automatically by GWT inside the web page. e.g. <iframe tabIndex="-1" id="org.ovirt.engine.ui.userportal.UserPortal" src="javascript:''" style="border-bottom: medium none; position: absolute; border-left: medium none; width: 0px; height: 0px; border-top: medium none; border-right: medium none;"> The message is similar to: http://stackoverflow.com/questions/4286517/gwt-application-generating-ie-insecure-item-warning Somebody recommended to use empty page inside src attribute, but for GWT it is probably hard to override here (http://ajaxian.com/archives/ie-frame-bug), e.g. <iframe ... src="blank.html"/> -- To view, visit http://gerrit.ovirt.org/11629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b5946a536fbc441cb6dca75f8dc36760164b534 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Libor Spevak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
