Alona Kaplan has posted comments on this change.
Change subject: webadmin: Added default created bond to comply with SuggestBox
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
Line 442: sourceListModel.setConfirmWindow(popupWindow);
Line 443: return;
Line 444: }
Line 445: bondPopup.getBond().setItems(freeBonds);
Line 446:
bondPopup.getBond().setSelectedItem(BondNameValidation.BOND_PREFIX);
Same code should be for old (3.0) bond window.
Consider moving the duplicated code to the BondModel to avoid duplication.
Also, the bond prefix should be some kind of mask- the user shouldn't be able
to delete it.
Line 447: bondPopup.getCommands().add(new UICommand("OK", new
BaseCommandTarget() { //$NON-NLS-1$
Line 448:
Line 449: @Override
Line 450: public void ExecuteCommand(UICommand command)
{
--
To view, visit http://gerrit.ovirt.org/12533
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b68f6b5f89089a7f78609b78df2e3e92827234d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
