Shireesh Anjal has posted comments on this change.
Change subject: gluster: added cluster level check
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
Line 165: result = validateMetrics();
Line 166: }
Line 167:
Line 168: if (getVdsGroup().supportsGlusterService()
Line 169: &&
!GlusterFeatureSupported.gluster(getVdsGroup().getcompatibility_version())) {
Here, "gluster" itself is the feature we are referring to. Gluster support has
been enabled from 3.1 onwards, and is not available in 3.0. So we need a
mechanism to detect that. e.g. If user tries to create a new cluster with
compatibility level 3.0 and gluster enabled, we should throw an error, which is
what this patch is trying to do.
Line 170:
addCanDoActionMessage(VdcBllMessages.GLUSTER_NOT_SUPPORTED);
Line 171:
addCanDoActionMessage(String.format("$compatibilityVersion %1$s",
getVdsGroup().getcompatibility_version().getValue()));
Line 172: result = false;
Line 173: }
--
To view, visit http://gerrit.ovirt.org/12970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3944e8b1d8d82eb19643b99f606da2364d6b582
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
