Daniel Erez has posted comments on this change.
Change subject: webadmin: adding migration role to a network.
......................................................................
Patch Set 3: Looks good to me, approved
(2 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterNetworkView.java
Line 71: }
Line 72: };
Line 73: getTable().addColumn(statusColumn, constants.statusNetwork());
Line 74:
Line 75: SafeHtmlWithSafeHtmlTooltipColumn<Network> roleColumn =
shouldn't it be extracted for re-usability?
Line 76: new SafeHtmlWithSafeHtmlTooltipColumn<Network>() {
Line 77: @Override
Line 78: public SafeHtml getValue(Network network) {
Line 79:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java
Line 102: }
Line 103: };
Line 104: getTable().addColumn(netRequiredColumn,
constants.requiredNetCluster(), "120px"); //$NON-NLS-1$
Line 105:
Line 106: SafeHtmlWithSafeHtmlTooltipColumn<PairQueryable<VDSGroup,
NetworkCluster>> netRoleColumn =
shouldn't it be extracted for re-usability?
Line 107: new
SafeHtmlWithSafeHtmlTooltipColumn<PairQueryable<VDSGroup, NetworkCluster>>() {
Line 108:
Line 109: @Override
Line 110: public SafeHtml getValue(PairQueryable<VDSGroup,
NetworkCluster> object) {
--
To view, visit http://gerrit.ovirt.org/12976
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752b182fd15f0557575ebe7e0271f6dd7a916f9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
