Alon Bar-Lev has posted comments on this change.
Change subject: pki: cleanup: favor Charset.forName() over plain string
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EncryptionUtils.java
Line 4: import java.io.FileInputStream;
Line 5: import java.io.IOException;
Line 6: import java.io.InputStream;
Line 7: import java.math.BigInteger;
Line 8: import java.nio.charset.Charset;
I just wounder... in our perception... where does code reuse ends...
Should we create a function for String.getBytes(Charset.forName("UTF-8")) as
getStringBytesAsUTF8(String str)? I mean why stop at "UTF-8"? Or why stop at
Charset.forName("UTF-8")?
Line 9: import java.security.GeneralSecurityException;
Line 10: import java.security.InvalidKeyException;
Line 11: import java.security.Key;
Line 12: import java.security.KeyStore;
--
To view, visit http://gerrit.ovirt.org/13192
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id61cad58356820a73683666235d328a72582486b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
