Sahina Bose has posted comments on this change. Change subject: gluster: improved gluster audit log util ......................................................................
Patch Set 3: In AuditLogableBase class, getter methods seem to be modifying the member variables - see getUserId(), getVmTemplateRefId() etc I think the setter methods should be changed to do this, and getter should then just return the variable. So like Shireesh suggested - change setVds() to also set mVdsId = value.getId() and getVdsId() would then just return mVdsId. -- To view, visit http://gerrit.ovirt.org/13001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52212ddb694d727248182d32abc1e1f5a21f76ee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
