Allon Mureinik has posted comments on this change. Change subject: core: Snapshot failure should not be retried. ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (3 inline comments) .................................................... Commit Message Line 5: CommitDate: 2013-03-21 19:47:22 +0200 Line 6: Line 7: core: Snapshot failure should not be retried. Line 8: Line 9: When snapshot VDS command throw any exception, engine should end the s/throw/throws/ Line 10: command with an appropriate audit log which indicates that restart is required, Line 11: instead retry the VDS command every 10 seconds and flood the event log. Line 12: Line 13: Change-Id: I8f56b025e0c6bbd9c9992ee65007a19c97658790 Line 6: Line 7: core: Snapshot failure should not be retried. Line 8: Line 9: When snapshot VDS command throw any exception, engine should end the Line 10: command with an appropriate audit log which indicates that restart is required, s/restart/a restart/ Line 11: instead retry the VDS command every 10 seconds and flood the event log. Line 12: Line 13: Change-Id: I8f56b025e0c6bbd9c9992ee65007a19c97658790 Line 14: Signed-off-by: Maor Lipchuk <[email protected]> Line 7: core: Snapshot failure should not be retried. Line 8: Line 9: When snapshot VDS command throw any exception, engine should end the Line 10: command with an appropriate audit log which indicates that restart is required, Line 11: instead retry the VDS command every 10 seconds and flood the event log. s/retry/of retrying/ s/flood/flooding/ Line 12: Line 13: Change-Id: I8f56b025e0c6bbd9c9992ee65007a19c97658790 Line 14: Signed-off-by: Maor Lipchuk <[email protected]> -- To view, visit http://gerrit.ovirt.org/13262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f56b025e0c6bbd9c9992ee65007a19c97658790 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
