Daniel Erez has uploaded a new change for review. Change subject: core: prevent rollback on VmReplicateDiskFinish success ......................................................................
core: prevent rollback on VmReplicateDiskFinish success Preventing rollback on execution success (moved rollback avoidance logic to revertTask). Change-Id: I06a8d395c729e915ece4e0ff413cb006542d4785 Bug-Url: https://bugzilla.redhat.com/923992 Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java 1 file changed, 4 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/06/13306/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java index b7ae2ff..16d2031 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java @@ -140,11 +140,6 @@ @Override public void endWithFailure() { super.endWithFailure(); - - // Preventing rollback on DeleteImageGroup failure - if (getEnclosingCommand().getReturnValue().getSucceeded()) { - getEnclosingCommand().getParameters().setExecutionIndex(0); - } } @Override @@ -164,7 +159,10 @@ @Override protected void revertTask() { - // No revert task - reverting is handled in the previous handler + // Preventing rollback on execution success + if (getEnclosingCommand().getReturnValue().getSucceeded()) { + getEnclosingCommand().getParameters().setExecutionIndex(0); + } } @Override -- To view, visit http://gerrit.ovirt.org/13306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I06a8d395c729e915ece4e0ff413cb006542d4785 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
