Ayal Baron has posted comments on this change.
Change subject: core:ExportVm.doesStorageDomainhaveSpaceForRequest
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
Line 145: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_SPECIFY_DOMAIN_IS_NOT_EXPORT_DOMAIN);
Line 146: }
Line 147: // check destination storage have free space
Line 148: int sizeInGB = (int) getVm().getActualDiskWithSnapshotsSize();
Line 149: if (!doesStorageDomainhaveSpaceForRequest(getStorageDomain(),
sizeInGB)) {
Removing the function below is ok because a similar one exists in
StorageDomainCommandBase, but it begs the question why here yes and in
AddDiskCommand, AddVmTemplateCommand, LiveMigrateVmDisksCommand.java etc?
Line 150: return false;
Line 151: }
Line 152:
Line 153: SnapshotsValidator snapshotValidator = new
SnapshotsValidator();
--
To view, visit http://gerrit.ovirt.org/13265
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia267125106c6465c064719c2718053644b556195
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
