Alon Bar-Lev has posted comments on this change.

Change subject: packaging: Updating apache templates with explicit values
......................................................................


Patch Set 1: (4 inline comments)

....................................................
File packaging/fedora/setup/ovirt-engine-proxy.conf.in
Line 17: # finish before the web server aborts the request as the default 
timeout
Line 18: # (controlled by the Timeout directive in httpd.conf) is 60 seconds.
Line 19: #
Line 20: #
Line 21: ProxyPass /ovirt-engine ajp://localhost:@JBOSS_AJP_PORT@ retry=5 
timeout=3600
Please consider ProxyPassMatch...

I will try...
Line 22: ProxyPass /UserPortal ajp://localhost:@JBOSS_AJP_PORT@/UserPortal 
retry=5 timeout=3600
Line 23: ProxyPass /OvirtEngineWeb 
ajp://localhost:@JBOSS_AJP_PORT@/OvirtEngineWeb retry=5 timeout=3600
Line 24: ProxyPass /Components ajp://localhost:@JBOSS_AJP_PORT@/Components 
retry=5 timeout=3600
Line 25: ProxyPass /webadmin ajp://localhost:@JBOSS_AJP_PORT@/webadmin retry=5 
timeout=3600


Line 26: ProxyPass /web-conf.js ajp://localhost:@JBOSS_AJP_PORT@/web-conf.js 
retry=5 timeout=3600
Line 27: ProxyPass /ca.crt ajp://localhost:@JBOSS_AJP_PORT@/ca.crt retry=5 
timeout=3600
Line 28: ProxyPass /engine.ssh.key.txt 
ajp://localhost:@JBOSS_AJP_PORT@/engine.ssh.key.txt retry=5 timeout=3600
Line 29: ProxyPass /rhevm.ssh.key.txt 
ajp://localhost:@JBOSS_AJP_PORT@/rhevm.ssh.key.txt retry=5 timeout=3600
Line 30: ProxyPass /docs/* ajp://localhost:@JBOSS_AJP_PORT@/docs/* retry=5 
timeout=3600
why here '*', I guess there is a reason... but I don't think it should.
Line 31: ProxyPass /spice ajp://localhost:@JBOSS_AJP_PORT@/spice retry=5 
timeout=3600
Line 32: ProxyPass /error ajp://localhost:@JBOSS_AJP_PORT@/error retry=5 
timeout=3600
Line 33: 
Line 34: #


Line 28: ProxyPass /engine.ssh.key.txt 
ajp://localhost:@JBOSS_AJP_PORT@/engine.ssh.key.txt retry=5 timeout=3600
Line 29: ProxyPass /rhevm.ssh.key.txt 
ajp://localhost:@JBOSS_AJP_PORT@/rhevm.ssh.key.txt retry=5 timeout=3600
Line 30: ProxyPass /docs/* ajp://localhost:@JBOSS_AJP_PORT@/docs/* retry=5 
timeout=3600
Line 31: ProxyPass /spice ajp://localhost:@JBOSS_AJP_PORT@/spice retry=5 
timeout=3600
Line 32: ProxyPass /error ajp://localhost:@JBOSS_AJP_PORT@/error retry=5 
timeout=3600
I guess you mean /404.html?
Line 33: 
Line 34: #
Line 35: # Remove the Expect headers from API requests (this is needed to fix a
Line 36: # problem with some API clients):


Line 34: #
Line 35: # Remove the Expect headers from API requests (this is needed to fix a
Line 36: # problem with some API clients):
Line 37: #
Line 38: <Location /api>
Nice!
Line 39:     ProxyPass ajp://localhost:@JBOSS_AJP_PORT@/api retry=5 timeout=3600
Line 40:     <IfModule mod_headers.c>
Line 41:       RequestHeader unset Expect early
Line 42:     </IfModule>


--
To view, visit http://gerrit.ovirt.org/13318
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89a47a99e28de0905183dc502cb0b35c80f77e6d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to