Allon Mureinik has posted comments on this change.
Change subject: core: log using INFO logging level rather than ERROR
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java
Line 53: return task.get();
Line 54: } catch (CancellationException e) {
Line 55: log.infoFormat("Failed to submit event using
submitEventSync (the event was cancelled)- pool {0} , exception {1}",
Line 56: event.getStoragePoolId(),
Line 57: e);
Do we really want the entire stacktrace?
Line 58: } catch (Exception e) {
Line 59: log.errorFormat("Failed at submitEventSync, for pool
{0} with exception {1}",
Line 60: event.getStoragePoolId(), e);
Line 61: }
--
To view, visit http://gerrit.ovirt.org/13311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If192b3ccc5f5310de4fd80ca7fb4a7d74d52e1df
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
