Allon Mureinik has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
......................................................................
Patch Set 11: Looks good to me, but someone else must approve
(2 inline comments)
@Alissa:
1. Please see my inline responses on patchset #9
2. When you rebase, please take care of those missing spaces.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
Line 57: return
failCanDoAction(VdcBllMessages.VALIDATION_STORAGE_CONNECTION_INVALID);
Line 58: }
Line 59:
Line 60: Guid vdsmId = getParameters().getVdsId();
Line 61: if(vdsmId == null || vdsmId.equals(Guid.Empty)) {
missing space after the "if" - please check your formatter
Line 62: return
failCanDoAction(VdcBllMessages.VDS_EMPTY_NAME_OR_ID);
Line 63: }
Line 64:
Line 65: Guid storagePoolId = getParameters().getStoragePoolId();
Line 62: return
failCanDoAction(VdcBllMessages.VDS_EMPTY_NAME_OR_ID);
Line 63: }
Line 64:
Line 65: Guid storagePoolId = getParameters().getStoragePoolId();
Line 66: if(storagePoolId == null || storagePoolId.equals(Guid.Empty) )
{
same here
Line 67: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_POOL_NOT_EXIST);
Line 68: }
Line 69:
Line 70: // Check if connection exists by id - otherwise there's
nothing to update
--
To view, visit http://gerrit.ovirt.org/12372
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaff5344ff191d6bdf53cc706c7bb796167a56b3
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
