Omer Frenkel has posted comments on this change.
Change subject: Trusted Compute Pools - Open Attestation integration with oVirt
engine proposal Detailed description:
http://wiki.ovirt.org/Trusted_compute_pools
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File
backend/manager/dbscripts/upgrade/03_02_0340_add_trusted_host_flag_to_vm_static.sql
Line 1: select fn_db_add_column('vm_static', 'trusted_host_flag', 'varchar(20)
default ''''');
why varchar and not boolean?
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
Line 67:
Line 68: @Column(name = "host_cpu_flags", nullable = false)
Line 69: private boolean useHostCpuFlags = false;
Line 70:
Line 71: private boolean trustedHostFlag;
since this is common between vm and template, you can just move this field with
its getter & setter to VmBase
Line 72:
Line 73: public VmStatic() {
Line 74: setNumOfMonitors(1);
Line 75: initialized = false;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
Line 78:
Line 79: @Transient
Line 80: private double actualDiskSize = 0;
Line 81:
Line 82: @Column(name = "trusted_host_flag", nullable = false)
no need for the @Column, when you'll rebase with master others @Columns will be
gone as well
Line 83: private boolean trustedHostFlag;
Line 84:
Line 85: public VmTemplate() {
Line 86: setAutoSuspend(false);
--
To view, visit http://gerrit.ovirt.org/11237
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4de780cd46069638433255f3f9c994575f752e55
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dave Chen <[email protected]>
Gerrit-Reviewer: Dave Chen <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
