Alon Bar-Lev has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
......................................................................
Patch Set 6: (2 inline comments)
OK... so the httpd configuration is verified as much as I can.
Few minor comments about the implementation.
....................................................
File packaging/fedora/setup/engine-setup.py
Line 244: "USE_DEFAULT" : True,
Line 245: "NEED_CONFIRM" : False,
Line 246: "CONDITION" : False},
Line 247:
Line 248: { "CMD_OPTION" :"override-httpd-root",
I don't see this in setup... in legacy I think we can drop this, and always do
this if httpd config override is set.
Line 249: "USAGE"
:output_messages.INFO_CONF_PARAMS_OVERRIDE_HTTPD_ROOT_USAGE,
Line 250: "PROMPT"
:output_messages.INFO_CONF_PARAMS_OVERRIDE_HTTPD_ROOT_PROMPT,
Line 251: "OPTION_LIST" :["yes","no"],
Line 252: "VALIDATION_FUNC" :validate.validateOptions,
Line 766: )
Line 767:
Line 768:
Line 769: # if redirection of root required, copy a file into the conf.d
folder.
Line 770: if controller.CONF["OVERRIDE_HTTPD_ROOT"] == "yes":
This always happens.
Line 771: utils.copyFile(
Line 772: basedefs.FILE_OVIRT_HTTPD_CONF_ROOT_TEMPLATE,
Line 773: basedefs.FILE_OVIRT_HTTPD_CONF_ROOT,
Line 774: )
--
To view, visit http://gerrit.ovirt.org/13318
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89a47a99e28de0905183dc502cb0b35c80f77e6d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
