Kanagaraj M has uploaded a new change for review.

Change subject: webadmin: display N/A for gluster services port if not 
applicable
......................................................................

webadmin: display N/A for gluster services port if not applicable

'SHD' services may not have port numbers and it will be displayed
as 'N/A' if portNo is 0.

Change-Id: I92485213c23ed26742b70db26c1230ea662bc0e5
Signed-off-by: Kanagaraj M <[email protected]>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/13336/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java
index 74fdece..6cbcd6f 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java
@@ -109,7 +109,7 @@
         clearButton.setLabel(constants.showAllService());
     }
 
-    protected void initTableColumns(ApplicationConstants constants) {
+    protected void initTableColumns(final ApplicationConstants constants) {
         // Table Entity Columns
         servicesTable.addEntityModelColumn(new 
EntityModelTextColumn<ServiceInfo>() {
             @Override
@@ -135,7 +135,12 @@
         servicesTable.addEntityModelColumn(new 
EntityModelTextColumn<ServiceInfo>() {
             @Override
             public String getText(ServiceInfo entity) {
-                return String.valueOf(entity.getPort());
+                if (entity.getPort() > 0) {
+                    return String.valueOf(entity.getPort());
+                }
+                else {
+                    return constants.notAvailableLabel();
+                }
             }
         }, constants.portService());
 


--
To view, visit http://gerrit.ovirt.org/13336
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92485213c23ed26742b70db26c1230ea662bc0e5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to