Vojtech Szocs has posted comments on this change. Change subject: webadmin: Guard against premature CommonModel nullification ......................................................................
Patch Set 1: Oh, I just realized that by removing assert statements in UiCommonModelResolver, I opened NPE possibility for classes using UiCommonModelResolver (the assert statement was meant to guard against "CommonModel == null" scenario). I'll submit new patch set that includes null checks in UiCommonModelResolver. -- To view, visit http://gerrit.ovirt.org/13326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bf55e75d97006d230bf503fac026722321435d0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
