Michael Pasternak has posted comments on this change.
Change subject: restapi: #920483 - Group Wrongly Displayed as User (within
permission)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
Line 167
Line 168
Line 169
Line 170
Line 171
both group and user are DbUser, so why removing this constraint? what is the
use-case?
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendEntityAssignedPermissionsResourceTest.java
Line 86: GetDbUserByUserIdParameters.class,
Line 87: new String[] { "UserId" },
Line 88: new Object[] { GUIDS[1] },
Line 89: getUserByIdx(1),
Line 90: 3);
why GetDbUserByUserId called three times now?
Line 91: setUpQueryExpectations("");
Line 92:
Line 93: collection.setUriInfo(uriInfo);
Line 94: verifyCollection(getCollection());
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUserAssignedPermissionsResourceTest.java
Line 53: GetDbUserByUserIdParameters.class,
Line 54: new String[] { "UserId" },
Line 55: new Object[] { GUIDS[1] },
Line 56: getUserByIdx(1),
Line 57: 3);
why GetDbUserByUserId called three times now?
Line 58: setUpQueryExpectations("");
Line 59: collection.setUriInfo(uriInfo);
Line 60: verifyCollection(getCollection());
Line 61: }
Line 68: GetDbUserByUserIdParameters.class,
Line 69: new String[] { "UserId" },
Line 70: new Object[] { GUIDS[1] },
Line 71: getUserByIdx(1),
Line 72: 3);
why GetDbUserByUserId called three times now?
Line 73: setUpQueryExpectations("", null, EVERYONE);
Line 74:
Line 75: collection.setUriInfo(uriInfo);
Line 76: verifyCollection(getCollection());
--
To view, visit http://gerrit.ovirt.org/13123
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08ad600d9b8af6dc8628a8ea9677d9c37fe89928
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
