Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: engine-service: rework start pid file handling ......................................................................
packaging: engine-service: rework start pid file handling There is no reason to force user to explicit stop and start the service in case pid file contains non running process. Change-Id: I8d8a7f8f8b7f5941f447df3d279686b973b5c393 Signed-off-by: Alon Bar-Lev <[email protected]> --- M packaging/fedora/engine-service.py.in 1 file changed, 1 insertion(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/15/13415/1 diff --git a/packaging/fedora/engine-service.py.in b/packaging/fedora/engine-service.py.in index f487f89..28dce86 100644 --- a/packaging/fedora/engine-service.py.in +++ b/packaging/fedora/engine-service.py.in @@ -394,16 +394,7 @@ # process is running and tell the user that the service needs # to be restarted: if enginePid: - if not isProcessRunning(enginePid): - raise Exception( - "The engine PID file \"%s\" contains %d but " - "that process doesn't exist. This means that " - "the engine crashed or was killed. You need " - "to explicitly run 'service ovirt-engine stop' " - "and then 'service ovirt-engine start' to " - "enable it again." % - (enginePidFile, enginePid)) - else: + if isProcessRunning(enginePid): syslog.syslog(syslog.LOG_WARNING, "The engine PID file \"%s\" exists and the " "process %d is running." % -- To view, visit http://gerrit.ovirt.org/13415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8d8a7f8f8b7f5941f447df3d279686b973b5c393 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
