Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: use kill to detect running processes
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/fedora/engine-service.py.in
Line 277:
Line 278:
Line 279: def isProcessRunning(pid):
Line 280: try:
Line 281: os.kill(pid, 0)
note that this fails if pid is running as privileged user and kill is running
as unprivileged user. You can check if pid is running just calling:
os.path.exists('/proc/%s' % pid)
Line 282: return True
Line 283: except OSError:
Line 284: return False
Line 285:
--
To view, visit http://gerrit.ovirt.org/13414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20238c634c418029c669bdf2b4b77e329b39faa1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
