Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: engine-service: recover from corrupted pid file ......................................................................
packaging: engine-service: recover from corrupted pid file The case in which pidfile is empty is common. Change-Id: I1b2a175cd0ef14bb6f60822f510059ee5be23c43 Signed-off-by: Alon Bar-Lev <[email protected]> --- M packaging/fedora/engine-service.py.in 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/13427/1 diff --git a/packaging/fedora/engine-service.py.in b/packaging/fedora/engine-service.py.in index de0d2ac..e08ffea 100644 --- a/packaging/fedora/engine-service.py.in +++ b/packaging/fedora/engine-service.py.in @@ -355,10 +355,14 @@ def loadEnginePid(): - if not os.path.exists(enginePidFile): - return None - with open(enginePidFile, "r") as enginePidFd: - return int(enginePidFd.read()) + ret = None + try: + if os.path.exists(enginePidFile): + with open(enginePidFile, "r") as enginePidFd: + ret = int(enginePidFd.readline()) + except ValueError: + pass + return ret def saveEnginePid(pid): -- To view, visit http://gerrit.ovirt.org/13427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1b2a175cd0ef14bb6f60822f510059ee5be23c43 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
