Yair Zaslavsky has posted comments on this change.
Change subject: engine: Simplify AuditLogHelper
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogHelper.java
Line 36: }
Line 37: return merge(returnValue, myAnnotations);
Line 38: }
Line 39:
Line 40: public static <T> Set<T> merge(Set<T> list, Set<T> items) {
I would rename also the variable. the name is now misleading :)
Line 41: if (list != null) {
Line 42: if (items != null) {
Line 43: list.addAll(items);
Line 44: }
--
To view, visit http://gerrit.ovirt.org/13422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf52160dba842985b6cb1fa66fc08c538b2ead6a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
