Arik Hadas has posted comments on this change.
Change subject: frontend: reduce duplicate code related to run-once capability
......................................................................
Patch Set 9: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
Line 739: tempVar4.setIsCancel(true);
Line 740: model.getCommands().add(tempVar4);
Line 741: }
Line 742:
Line 743: private void OnRunOnce()
yes of course I can but it will just make tight coupling between them, so I
prefer not to pass it. if we had somekind of interface for the callback I would
probably agree but I don't want to pass the ListModel - someone might start to
modify it there..
Line 744: {
Line 745: UserPortalItemModel selectedItem = (UserPortalItemModel)
getSelectedItem();
Line 746: if (selectedItem == null || selectedItem.getEntity() == null)
Line 747: {
--
To view, visit http://gerrit.ovirt.org/13207
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6561df71f093e2739e689722ead4f85428c04d06
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
