Shireesh Anjal has posted comments on this change.
Change subject: engine: Unit test cases for create gluster volume command
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
Thanks for the initiative :)
One minor comment in-line.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java
Line 103: volumeEntity.setBricks(getBricks(volumeEntity.getId(),
brickCount, withDuplicateBricks));
Line 104: return volumeEntity;
Line 105: }
Line 106:
Line 107: private List<GlusterBrickEntity> getBricks(Guid volumeId, int
max, boolean withDuplicates) {
The second argument is never called with value "true" ?
Line 108: List<GlusterBrickEntity> bricks = new
ArrayList<GlusterBrickEntity>();
Line 109: GlusterBrickEntity brick = null;
Line 110: for (Integer i = 0; i < max; i++) {
Line 111: brick =
--
To view, visit http://gerrit.ovirt.org/13238
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26c6df7c6697abd786a5625783e17d4293c7241
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
