Yair Zaslavsky has posted comments on this change.
Change subject: engine,restapi:Enable Gluster Hooks-types & constants defined
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Missing entry at AuditLogMessages.properties.
What about audit log type for disabling gluster hook?
If you want to use the same audit log type for both enable and disable (i.e -
pass boolean parameter) maybe it should be TOGGLE_GLUSTER_HOOK.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 101:
severities.put(AuditLogType.GLUSTER_VOLUME_BRICK_REMOVED_FROM_CLI,
AuditLogSeverity.WARNING);
Line 102: severities.put(AuditLogType.GLUSTER_SERVER_REMOVED_FROM_CLI,
AuditLogSeverity.WARNING);
Line 103: severities.put(AuditLogType.GLUSTER_VOLUME_STARTED_FROM_CLI,
AuditLogSeverity.WARNING);
Line 104: severities.put(AuditLogType.GLUSTER_VOLUME_STOPPED_FROM_CLI,
AuditLogSeverity.WARNING);
Line 105: severities.put(AuditLogType.GLUSTER_HOOK_ENABLE,
AuditLogSeverity.NORMAL);
is there also gluster hook disable?
Line 106: severities.put(AuditLogType.GLUSTER_HOOK_ENABLE_FAILED,
AuditLogSeverity.ERROR);
Line 107: }
Line 108:
Line 109: private static void initDefaultSeverities() {
--
To view, visit http://gerrit.ovirt.org/13269
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bd64caf28ac67c8bba5146d97cd7c17fa4c0899
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
