Moti Asayag has posted comments on this change. Change subject: engine: Removing CustomLogFields annotattion (Second super fix in AuditLogDirector) ......................................................................
Patch Set 1: (4 inline comments) minor typo comments - besides - very good patch. .................................................... Commit Message Line 3: AuthorDate: 2013-04-03 09:50:47 +0300 Line 4: Commit: Michael Kublin <[email protected]> Line 5: CommitDate: 2013-04-03 09:55:58 +0300 Line 6: Line 7: engine: Removing CustomLogFields annotattion (Second super fix in AuditLogDirector) s/annotattion/annotation Line 8: Line 9: After some investigation I found out that we don't need CustomLogFields annotaattion at all, this Line 10: is a best optimization which can be done here. Line 11: We don't need it because of all required names of parameters are located inside our audit log message Line 5: CommitDate: 2013-04-03 09:55:58 +0300 Line 6: Line 7: engine: Removing CustomLogFields annotattion (Second super fix in AuditLogDirector) Line 8: Line 9: After some investigation I found out that we don't need CustomLogFields annotaattion at all, this s/annotattion/annotation Line 10: is a best optimization which can be done here. Line 11: We don't need it because of all required names of parameters are located inside our audit log message Line 12: and their values will be retrieved via reflection, that's why we don't need to keep additional list of Line 13: parameters names inside annotattion. Line 12: and their values will be retrieved via reflection, that's why we don't need to keep additional list of Line 13: parameters names inside annotattion. Line 14: Line 15: Benefits: Line 16: 1. Reduced number of operations for processing annotattion (Improved CPU consaption) s/consaption/consumption Line 17: 2. Simplified development of audit log messages, no need for annotattion. Line 18: 3. Code becomes understandable for everyone (at least I hope) Line 19: Line 20: This is a kind of patch that I like: Line 13: parameters names inside annotattion. Line 14: Line 15: Benefits: Line 16: 1. Reduced number of operations for processing annotattion (Improved CPU consaption) Line 17: 2. Simplified development of audit log messages, no need for annotattion. s/annotattion/annotation Line 18: 3. Code becomes understandable for everyone (at least I hope) Line 19: Line 20: This is a kind of patch that I like: Line 21: 1. Improved perfromance -- To view, visit http://gerrit.ovirt.org/13544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied60d0000e26158baee64c83540d683093485dd8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
