Sandro Bonazzola has uploaded a new change for review.

Change subject: sos - fixed behaviour when -a option is used
......................................................................

sos - fixed behaviour when -a option is used

calling sosreport -a -o engine set all the
engine plugin options to True which was an
unexpected and unhandled value.

Change-Id: Ibbaec1408a581f8121339d79f66a0afcc07495b8
Signed-off-by: Sandro Bonazzola <[email protected]>
---
M src/sos/plugins/engine.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-log-collector 
refs/changes/52/13552/1

diff --git a/src/sos/plugins/engine.py b/src/sos/plugins/engine.py
index 9f75ff2..a56bed4 100644
--- a/src/sos/plugins/engine.py
+++ b/src/sos/plugins/engine.py
@@ -24,7 +24,10 @@
         self.addCopySpec("/etc/sysconfig/ovirt-engine")
         self.addCopySpec("/usr/share/ovirt-engine/conf")
         self.addCopySpec("/var/log/ovirt-guest-agent")
-        if self.getOption("vdsmlogs"):
+        if (
+            self.getOption("vdsmlogs") and
+            self.getOption("vdsmlogs") is not True
+        ):
             self.addCopySpec(self.getOption("vdsmlogs"))
 
     def postproc(self):


--
To view, visit http://gerrit.ovirt.org/13552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbaec1408a581f8121339d79f66a0afcc07495b8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to