Tomas Jelinek has posted comments on this change.
Change subject: engine: Fixes in non plugin console invocation
......................................................................
Patch Set 3: (2 inline comments)
just minor comments, otherwise looks ok
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java
Line 196:
Line 197: return false;
Line 198: }
Line 199:
Line 200: private boolean isLinuxAndFirefox() {
you can use the TypeResolver.Resolve(Configurator.class).isClientLinuxFirefox()
instead
Line 201: return (cat.os.equalsIgnoreCase("Linux")) //$NON-NLS-1$
Line 202: &&
(cat.browser.equalsIgnoreCase("Firefox"));//$NON-NLS-1$
Line 203: }
Line 204:
Line 201: return (cat.os.equalsIgnoreCase("Linux")) //$NON-NLS-1$
Line 202: &&
(cat.browser.equalsIgnoreCase("Firefox"));//$NON-NLS-1$
Line 203: }
Line 204:
Line 205: private boolean isWindowsAndIE() {
you can use the
TypeResolver.Resolve(Configurator.class).isClientWindownsExplorer() instead
Line 206: return (cat.os.equalsIgnoreCase("Windows")) //$NON-NLS-1$
Line 207: && (cat.browser.equalsIgnoreCase("Explorer"));
//$NON-NLS-1$
Line 208: }
Line 209:
--
To view, visit http://gerrit.ovirt.org/13332
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fe6fbf274a9ac215e8f6593cc000f778a431928
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Libor Spevak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
