Gilad Chaplik has posted comments on this change. Change subject: webadmin: null checks added for Volume general model properties ......................................................................
Patch Set 1: Looks good to me, approved (1 inline comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java Line 103: setName(entity.getName()); Line 104: setVolumeId(entity.getId() != null ? entity.getId().toString() : null); Line 105: setVolumeType(entity.getVolumeType() != null ? entity.getVolumeType().toString() : null); Line 106: setReplicaCount(entity.getReplicaCount() != null ? Integer.toString(entity.getReplicaCount()) : null); Line 107: setStripeCount(entity.getStripeCount() != null ? Integer.toString(entity.getStripeCount()) : null); consider using String.valueOf(Integer) instead of ternary operation. although 'null' will be printed, maybe it's right :-) Line 108: setNumOfBricks(entity.getBricks() != null ? Integer.toString(entity.getBricks().size()) : null); Line 109: } Line 110: -- To view, visit http://gerrit.ovirt.org/13551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaa6463054d6eefd589f5991c43b09b7d9247507 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
