Allon Mureinik has uploaded a new change for review. Change subject: core: Remove IsVdsWithSameHostExistsQurey ......................................................................
core: Remove IsVdsWithSameHostExistsQurey This patch removes the unused IsVdsWithSameHostExistQuery. Removed in this patch: 1. The IsVdsWithSameHostExistQuery class. 2. The IsVdsWithSameHostExistParameters class only used by the aforementioned query. 3. The IsVdsWithSameHostExist constant from VdcQueryType corresponding to the aforementioned query. 4. The isVdsWithSameHostExists and isVdsWithSameHostExsitsStatic methods in VdsHandler which are no longer in use. Change-Id: If6387786899342cf1c9e242aded0ee56053604bc Signed-off-by: Allon Mureinik <[email protected]> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVdsWithSameHostExistQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsWithSameHostExistParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 4 files changed, 0 insertions(+), 42 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/90/13590/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVdsWithSameHostExistQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVdsWithSameHostExistQuery.java deleted file mode 100644 index a8194dc..0000000 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVdsWithSameHostExistQuery.java +++ /dev/null @@ -1,14 +0,0 @@ -package org.ovirt.engine.core.bll; - -import org.ovirt.engine.core.common.queries.*; - -public class IsVdsWithSameHostExistQuery<P extends IsVdsWithSameHostExistParameters> extends QueriesCommandBase<P> { - public IsVdsWithSameHostExistQuery(P parameters) { - super(parameters); - } - - @Override - protected void executeQueryCommand() { - getQueryReturnValue().setReturnValue(VdsHandler.isVdsWithSameHostExistStatic(getParameters().getHostName())); - } -} diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java index e9c3103..dc07193 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java @@ -67,16 +67,8 @@ } - public boolean isVdsWithSameHostExist(String hostName) { - return isVdsWithSameHostExistStatic(hostName); - } - public boolean isVdsWithSameIpExists(String ipAddress) { return isVdsWithSameIpExistsStatic(ipAddress); - } - - public static boolean isVdsWithSameHostExistStatic(String hostName) { - return DbFacade.getInstance().getVdsStaticDao().getByHostName(hostName) != null; } public static boolean isVdsWithSameIpExistsStatic(String ipAddress) { diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsWithSameHostExistParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsWithSameHostExistParameters.java deleted file mode 100644 index 2a0b889..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsWithSameHostExistParameters.java +++ /dev/null @@ -1,18 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -public class IsVdsWithSameHostExistParameters extends VdcQueryParametersBase { - private static final long serialVersionUID = 8539975719107135326L; - - public IsVdsWithSameHostExistParameters(String hostName) { - _hostName = hostName; - } - - private String _hostName; - - public String getHostName() { - return _hostName; - } - - public IsVdsWithSameHostExistParameters() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java index 9114fa6..1874435 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java @@ -17,8 +17,6 @@ IsBalloonEnabled(VdcQueryAuthType.User), // Vds queries - IsVdsWithSameNameExist, - IsVdsWithSameHostExist, IsVdsWithSameIpExists, GetVdsByVdsId, GetVdsByHost, -- To view, visit http://gerrit.ovirt.org/13590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If6387786899342cf1c9e242aded0ee56053604bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
