Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: major cleanup
......................................................................
Patch Set 1: (1 inline comment)
Hi,
Appreciate any review. This is the last large change I am planning to service,
I think it looks good now.
Thanks!
....................................................
File packaging/fedora/engine-service.py.in
Line 814:
Line 815: # Prepare a clean environment:
Line 816: # TODO: why? this is not healthy
Line 817: #engineEnv = os.environ.copy()
Line 818: engineEnv = {}
We need to discuss this... it is not healthy to reset environment from whatever
init.d sets.
Line 819: engineEnv.update({
Line 820: 'PATH':
'/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin',
Line 821: 'LANG': 'en_US.UTF-8',
Line 822: 'ENGINE_DEFAULTS': Config.ENGINE_DEFAULT_FILE,
--
To view, visit http://gerrit.ovirt.org/13628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea45e8131190f41171e937699ec2e261939c4bd9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
