Tomas Jelinek has posted comments on this change.
Change subject: engine,webadmin: Run and pause action enabled
......................................................................
Patch Set 2: (2 inline comments)
If I understand correctly, the isRunAndPauseEditor is visible in new/edit pool,
vm and template dialogs,
however only the new/edit vm uses it properly. The new template stores it, but
does not read it anymore (e.g. in edit it is ignored) and pool ignores it
completly.
If the intention is to have it only on the VM, than please hide it from pool
and template dialogs.
If you want to use it in template and pool as well than please handle them
properly also in
template/pool list models and behavior classes.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Line 619:
Line 620: private NotChangableForVmInPoolEntityModel privateIsRunAndPause;
Line 621:
Line 622: public EntityModel getIsRunAndPause()
Line 623: {
please use java formatting for new code
Line 624: return privateIsRunAndPause;
Line 625: }
Line 626:
Line 627: private void setIsRunAndPause(NotChangableForVmInPoolEntityModel
value)
Line 624: return privateIsRunAndPause;
Line 625: }
Line 626:
Line 627: private void setIsRunAndPause(NotChangableForVmInPoolEntityModel
value)
Line 628: {
same
Line 629: privateIsRunAndPause = value;
Line 630: }
Line 631:
Line 632: private NotChangableForVmInPoolEntityModel
privateIsDeleteProtected;
--
To view, visit http://gerrit.ovirt.org/13564
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1fe46a9946f7914095310ddac9ab1a9e5a6564b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Libor Spevak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
