Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: engine-service: do not clean environment ......................................................................
packaging: engine-service: do not clean environment the init system may put important variables in environment. add LC_ALL as java is effected by AC_CTYPE per defaults of string conversions, as if it is set by init it will effect us. in practice we should only set LC_CTYPE or use jnu.encoding, when we are sure that no default locale is used for conversions within application. Change-Id: Ia8231b343574df83e65c55d9ffa75698a3f2d692 Signed-off-by: Alon Bar-Lev <[email protected]> --- M packaging/fedora/engine-service.py.in 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/13643/1 diff --git a/packaging/fedora/engine-service.py.in b/packaging/fedora/engine-service.py.in index 6174d31..eea18f1 100644 --- a/packaging/fedora/engine-service.py.in +++ b/packaging/fedora/engine-service.py.in @@ -494,10 +494,12 @@ "org.jboss.as.standalone", "-c", os.path.basename(jbossConfigFile), ]) - # Prepare a clean environment: - engineEnv = { + # Prepare environment: + engineEnv = os.environ.copy() + engineEnv.update({ "PATH": "/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin", "LANG": "en_US.UTF-8", + "LC_ALL": "en_US.UTF-8", "ENGINE_DEFAULTS": engineDefaultsFile, "ENGINE_VARS": engineConfigFile, "ENGINE_ETC": engineEtcDir, @@ -506,7 +508,7 @@ "ENGINE_USR": engineUsrDir, "ENGINE_VAR": engineVarDir, "ENGINE_CACHE": engineCacheDir, - } + }) # this is required to allow # writing after user id is changed -- To view, visit http://gerrit.ovirt.org/13643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia8231b343574df83e65c55d9ffa75698a3f2d692 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
