Michael Pasternak has posted comments on this change.
Change subject: cli: connect --help will log the user out of the disconnected
cli
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File src/ovirtcli/shell/engineshell.py
Line 106: if not s.startswith('#'):
Line 107: rg = re.compile('((?:[a-z][a-z]+))(
)(-)(-)(help)',re.IGNORECASE|re.DOTALL)
Line 108: m = rg.search(s)
Line 109: if m:
Line 110: s = 'help ' + m.group(1)
1. this should happen in precmd()
2. i'd prefer you taking out this code in to dedicated method such as
normalize() for instance
Line 111: command = s.split(' ')[0]
Line 112: if command == '' and not self.__input_buffer:
Line 113: pass
Line 114: elif self.context.connection == None and command not in
EngineShell.OFF_LINE_CONTENT:
--
To view, visit http://gerrit.ovirt.org/13494
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icffe101260edc5072aec4c8d2a6df0f763591f8b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
