Ravi Nori has posted comments on this change.
Change subject: engine : ovirt-node enter installing status when the install
fails
......................................................................
Patch Set 5: (2 inline comments)
Hi Kublin, Please see my comments
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
Line 33: @NonTransactiveCommandAttribute(forceCompensation = true)
Line 34: public class UpdateVdsCommand<T extends UpdateVdsActionParameters>
extends VdsCommand<T> implements RenamedEntityInfoProvider{
Line 35:
Line 36: private VDS _oldVds;
Line 37: private static final List<String> UPDATE_FIELDS_VDS_BROKER =
Arrays.asList("host_name", "ip", "vds_unique_id", "port", "vds_group_id");
Will add it
Line 38:
Line 39: public UpdateVdsCommand(T parameters) {
Line 40: super(parameters);
Line 41: }
Line 199: getCompensationContext().stateChanged();
Line 200: return null;
Line 201: }
Line 202: });
Line 203:
If I add VdsDynamic to compensation context here I think there is an issue with
the status displayed for the host. Please see the flow below and let me know
what the end status should be.
1. The host is in Maintenance statue
2. We initiate Install and status changes to Installing here
3. When canDoAction of InstallVds command succeeds but execute command fails
the status is changed to InstallFailed by InstallVdsCommand
4. The compensation logic will see that the command has failed and will
compensate to change status to Maintenance.
I thought the status should be Installed Failed in this case so did not add
VdsDynamic to compensation context here. Please let me know
Line 204: if (getParameters().getInstallVds()) {
Line 205: runVdsCommand(VDSCommandType.SetVdsStatus,
Line 206: new SetVdsStatusVDSCommandParameters(getVdsId(),
VDSStatus.Installing));
Line 207: }
--
To view, visit http://gerrit.ovirt.org/13622
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d74e946cb68d2b9dbc11fc5c6bed9f63ba35fe2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
