Alon Bar-Lev has posted comments on this change.
Change subject: userportal, webadmin: branding support[WIP].
......................................................................
Patch Set 4: (3 inline comments)
Some minor notes regardless our discussion.
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/branding/BrandingManager.java
Line 55: * Constructor that takes a {@code File} object to configure the
brandingRootPath.
Line 56: * @param etcDir A {@code File} pointing to the branding root path.
Line 57: */
Line 58: public BrandingManager(final File etcDir) {
Line 59: brandingRootPath = new File(etcDir + BRANDING_PATH);
new File(etcDir, BRANDING_PATH)
and remove / from BRANDING_PATH
Line 60: }
Line 61:
Line 62: /**
Line 63: * Get a list of available {@code BrandingTheme}s.
Line 70: List<File> directories = Arrays.asList(
Line 71: brandingRootPath.listFiles(new FileFilter() {
Line 72: @Override
Line 73: public boolean accept(final File file) {
Line 74: return file.isDirectory();
Be sure this accepts synlink
Line 75: }
Line 76: }));
Line 77: for (File directory : directories) {
Line 78: BrandingTheme theme = new BrandingTheme(
Line 82: }
Line 83: }
Line 84: Collections.sort(themes);
Line 85: // Reverse so the lowest order is at the top.
Line 86: Collections.reverse(themes);
No need to reverse... just state the order of override either 01 overrides 02
or 02 override 01
Line 87: }
Line 88: return themes;
Line 89: }
Line 90:
--
To view, visit http://gerrit.ovirt.org/13181
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a8a426ce7d688d33c5ae2b70632c836843106b2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
